diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-23 16:14:26 +0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2018-08-03 18:05:49 +0800 |
| commit | 1c96dde100987149f42bd6dd97013f7c421f27c7 (patch) | |
| tree | 073e1079bfdb99cc65761e3b7881e63a70f0b9e6 /drivers/crypto | |
| parent | 43490e8046b5d273eb82710b04290c5997138adc (diff) | |
| download | op-kernel-dev-1c96dde100987149f42bd6dd97013f7c421f27c7.zip op-kernel-dev-1c96dde100987149f42bd6dd97013f7c421f27c7.tar.gz | |
crypto: cavium/nitrox - Replace GFP_ATOMIC with GFP_KERNEL in crypto_alloc_context()
crypto_alloc_context() is only called by nitrox_skcipher_init(), which is
never called in atomic context.
crypto_alloc_context() calls dma_pool_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/cavium/nitrox/nitrox_lib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/cavium/nitrox/nitrox_lib.c b/drivers/crypto/cavium/nitrox/nitrox_lib.c index 4fdc921..ebe2673 100644 --- a/drivers/crypto/cavium/nitrox/nitrox_lib.c +++ b/drivers/crypto/cavium/nitrox/nitrox_lib.c @@ -148,7 +148,7 @@ void *crypto_alloc_context(struct nitrox_device *ndev) void *vaddr; dma_addr_t dma; - vaddr = dma_pool_alloc(ndev->ctx_pool, (GFP_ATOMIC | __GFP_ZERO), &dma); + vaddr = dma_pool_alloc(ndev->ctx_pool, (GFP_KERNEL | __GFP_ZERO), &dma); if (!vaddr) return NULL; |
