summaryrefslogtreecommitdiffstats
path: root/drivers/crypto/nx
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-07-15 14:09:13 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2016-07-19 12:01:47 +0800
commite514cc0a492a3f39ef71b31590a7ef67537ee04b (patch)
tree1c6831264fb290aa4f54f25f318deadc7d5257e9 /drivers/crypto/nx
parenta6d7bfd0ff21f258913dd5e626d2bd70ab3942df (diff)
downloadop-kernel-dev-e514cc0a492a3f39ef71b31590a7ef67537ee04b.zip
op-kernel-dev-e514cc0a492a3f39ef71b31590a7ef67537ee04b.tar.gz
crypto: nx - off by one bug in nx_of_update_msc()
The props->ap[] array is defined like this: struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3]; So we can see that if msc->fc and msc->mode are == to NX_MAX_FC or NX_MAX_MODE then we're off by one. Fixes: ae0222b7289d ('powerpc/crypto: nx driver code supporting nx encryption') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/nx')
-rw-r--r--drivers/crypto/nx/nx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c
index 0794f1c..42f0f22 100644
--- a/drivers/crypto/nx/nx.c
+++ b/drivers/crypto/nx/nx.c
@@ -392,7 +392,7 @@ static void nx_of_update_msc(struct device *dev,
((bytes_so_far + sizeof(struct msc_triplet)) <= lenp) &&
i < msc->triplets;
i++) {
- if (msc->fc > NX_MAX_FC || msc->mode > NX_MAX_MODE) {
+ if (msc->fc >= NX_MAX_FC || msc->mode >= NX_MAX_MODE) {
dev_err(dev, "unknown function code/mode "
"combo: %d/%d (ignored)\n", msc->fc,
msc->mode);
OpenPOWER on IntegriCloud