summaryrefslogtreecommitdiffstats
path: root/drivers/cpufreq/imx6q-cpufreq.c
diff options
context:
space:
mode:
authorViresh Kumar <viresh.kumar@linaro.org>2013-12-02 11:04:13 +0530
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-01-06 01:43:44 +0100
commitab1b1c4e8223f9ee66aa93aaf64c36e77cadffac (patch)
treeb592025459590a4564fd8e7760707c7d77a159e1 /drivers/cpufreq/imx6q-cpufreq.c
parentf7ba3b41e27129575201f0f9656e83fb67e86c3b (diff)
downloadop-kernel-dev-ab1b1c4e8223f9ee66aa93aaf64c36e77cadffac.zip
op-kernel-dev-ab1b1c4e8223f9ee66aa93aaf64c36e77cadffac.tar.gz
cpufreq: send new set of notification for transition failures
In the current code, if we fail during a frequency transition, we simply send the POSTCHANGE notification with the old frequency. This isn't enough. One of the core users of these notifications is the code responsible for keeping loops_per_jiffy aligned with frequency changes. And mostly it is written as: if ((val == CPUFREQ_PRECHANGE && freq->old < freq->new) || (val == CPUFREQ_POSTCHANGE && freq->old > freq->new)) { update-loops-per-jiffy... } So, suppose we are changing to a higher frequency and failed during transition, then following will happen: - CPUFREQ_PRECHANGE notification with freq-new > freq-old - CPUFREQ_POSTCHANGE notification with freq-new == freq-old The first one will update loops_per_jiffy and second one will do nothing. Even if we send the 2nd notification by exchanging values of freq-new and old, some users of these notifications might get unstable. This can be fixed by simply calling cpufreq_notify_post_transition() with error code and this routine will take care of sending notifications in the correct order. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> [rjw: Folded 3 patches into one, rebased unicore2 changes] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/imx6q-cpufreq.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud