diff options
author | Eric Anholt <eric@anholt.net> | 2008-11-04 12:01:24 -0800 |
---|---|---|
committer | Dave Airlie <airlied@linux.ie> | 2008-11-11 17:44:22 +1000 |
commit | bd95e0a4a6bb9485fe35dda62719663f6ceabae1 (patch) | |
tree | 72e0665fb8585f3f2b68a7c1fbc10baf5bbbb5c3 /drivers/connector | |
parent | d3e74d0237b102d34979015fbf6df02ca4413074 (diff) | |
download | op-kernel-dev-bd95e0a4a6bb9485fe35dda62719663f6ceabae1.zip op-kernel-dev-bd95e0a4a6bb9485fe35dda62719663f6ceabae1.tar.gz |
i915: Remove racy delayed vblank swap ioctl.
When userland detected that this ioctl was supported (by version number check),
it used it in a racy way -- dispatch delayed swap, wait for vblank, continue
rendering. As there was no mechanism for it to wait for the swap to finish,
sometimes it would render before the swap and garbage would be displayed on
the screen.
By removing the ioctl and returning -EINVAL, userland returns to its previous,
correct rendering path of waiting for a vblank then dispatching a swap. The
only path that could have used this ioctl correctly was page flipping, which
relied on only one client running and emitting wait-for-vblank-before-rendering
in the command stream. That path also falls back correctly, at the performance
cost of not being able to queue up rendering before the flip occurs.
Signed-off-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Dave Airlie <airlied@linux.ie>
Diffstat (limited to 'drivers/connector')
0 files changed, 0 insertions, 0 deletions