diff options
| author | Stephen Boyd <sboyd@codeaurora.org> | 2016-01-29 17:09:01 -0800 |
|---|---|---|
| committer | Stephen Boyd <sboyd@codeaurora.org> | 2016-01-29 17:11:02 -0800 |
| commit | 3d6f1c7212d0823cbc056b1c184c7fe0cfef553a (patch) | |
| tree | bdc54561d15c3f79b97142a59b16167d1f51a816 /drivers/clk/clk-axi-clkgen.c | |
| parent | 62d1e7823d9c3b454dcbffd58f35c5fa96172644 (diff) | |
| download | op-kernel-dev-3d6f1c7212d0823cbc056b1c184c7fe0cfef553a.zip op-kernel-dev-3d6f1c7212d0823cbc056b1c184c7fe0cfef553a.tar.gz | |
clk: axi-clkgen: Remove sometimes impossible check
The size of unsigned long on 64-bit architectures is equal to the
size of u64, so this check is impossible there. This throws off
static checkers:
drivers/clk/clk-axi-clkgen.c:331 axi_clkgen_recalc_rate() warn:
impossible condition '(tmp > (~0)) => (0-u64max > u64max)'
Let's change this code to use min_t() instead so that we
get the same effect on architectures where sizeof(unsigned long)
doesn't equal sizeof(u64).
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/clk-axi-clkgen.c')
| -rw-r--r-- | drivers/clk/clk-axi-clkgen.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/clk/clk-axi-clkgen.c b/drivers/clk/clk-axi-clkgen.c index 9a0744c..3294db3 100644 --- a/drivers/clk/clk-axi-clkgen.c +++ b/drivers/clk/clk-axi-clkgen.c @@ -328,10 +328,7 @@ static unsigned long axi_clkgen_recalc_rate(struct clk_hw *clk_hw, tmp = (unsigned long long)(parent_rate / d) * m; do_div(tmp, dout); - if (tmp > ULONG_MAX) - return ULONG_MAX; - - return tmp; + return min_t(unsigned long long, tmp, ULONG_MAX); } static int axi_clkgen_enable(struct clk_hw *clk_hw) |
