summaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2015-02-02 15:44:54 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-25 11:44:52 +0100
commitbd735995308b553cc3c7f6a975aa284b270c7e2c (patch)
tree599cbb2f030ab78d8a136b7f00fd16bda2e2f799 /drivers/char
parent2f9763190dd6356eec95548f4cfa8a36a71f767c (diff)
downloadop-kernel-dev-bd735995308b553cc3c7f6a975aa284b270c7e2c.zip
op-kernel-dev-bd735995308b553cc3c7f6a975aa284b270c7e2c.tar.gz
misc: Add attribute groups
Add groups field to struct miscdevice for passing the attribute groups at device creation. In this way, the driver can avoid the manual call of device_create_file() after the device registration, which is basically a racy operation, in addition to the reduction of manual device_remove_file() calls. Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/misc.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index c892c29..5bb3a21 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -207,8 +207,9 @@ int misc_register(struct miscdevice * misc)
dev = MKDEV(MISC_MAJOR, misc->minor);
- misc->this_device = device_create(misc_class, misc->parent, dev,
- misc, "%s", misc->name);
+ misc->this_device =
+ device_create_with_groups(misc_class, misc->parent, dev,
+ misc, misc->groups, "%s", misc->name);
if (IS_ERR(misc->this_device)) {
int i = DYNAMIC_MINORS - misc->minor - 1;
if (i < DYNAMIC_MINORS && i >= 0)
OpenPOWER on IntegriCloud