summaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorBorislav Petkov <borislav.petkov@amd.com>2010-09-03 18:39:41 +0200
committerIngo Molnar <mingo@elte.hu>2010-09-05 14:28:34 +0200
commit1b13fe6a6e9986dbc079cbb05090be75edbffa5d (patch)
treefeabf768d5ed72f9f89d8caeb1c95fe996904961 /drivers/char
parent260133ab658bd2b80e07832a878e00405e19ff43 (diff)
downloadop-kernel-dev-1b13fe6a6e9986dbc079cbb05090be75edbffa5d.zip
op-kernel-dev-1b13fe6a6e9986dbc079cbb05090be75edbffa5d.tar.gz
AGP: Warn when GATT memory cannot be set to UC
This is one of those paranoid checks which should at least tell us that something is about to go haywire after we've disabled GART table walk probes which is done by default now on AMD. Signed-off-by: Borislav Petkov <borislav.petkov@amd.com> Cc: Dave Airlie <airlied@redhat.com> Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> LKML-Reference: <1283531981-7495-4-git-send-email-bp@amd64.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/agp/generic.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index d2abf51..64255ce 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -984,7 +984,9 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)
bridge->driver->cache_flush();
#ifdef CONFIG_X86
- set_memory_uc((unsigned long)table, 1 << page_order);
+ if (set_memory_uc((unsigned long)table, 1 << page_order))
+ printk(KERN_WARNING "Could not set GATT table memory to UC!");
+
bridge->gatt_table = (void *)table;
#else
bridge->gatt_table = ioremap_nocache(virt_to_phys(table),
OpenPOWER on IntegriCloud