summaryrefslogtreecommitdiffstats
path: root/drivers/char/synclink_gt.c
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-08-11 20:01:46 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2010-08-23 18:17:21 -0700
commit80d04f22b0869a1145b36a90a83a79603ac92be8 (patch)
tree196b465c243e3b230530ffeda8ef3396bdd82a94 /drivers/char/synclink_gt.c
parent49bf7eaffc0c252ab2a2cc8f1bf8c0077e778704 (diff)
downloadop-kernel-dev-80d04f22b0869a1145b36a90a83a79603ac92be8.zip
op-kernel-dev-80d04f22b0869a1145b36a90a83a79603ac92be8.tar.gz
synclink: add mutex_unlock() on error path
There is a path which still holds its mutex here. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/char/synclink_gt.c')
-rw-r--r--drivers/char/synclink_gt.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/char/synclink_gt.c b/drivers/char/synclink_gt.c
index fef80cf..e63b830 100644
--- a/drivers/char/synclink_gt.c
+++ b/drivers/char/synclink_gt.c
@@ -691,8 +691,10 @@ static int open(struct tty_struct *tty, struct file *filp)
if (info->port.count == 1) {
/* 1st open on this device, init hardware */
retval = startup(info);
- if (retval < 0)
+ if (retval < 0) {
+ mutex_unlock(&info->port.mutex);
goto cleanup;
+ }
}
mutex_unlock(&info->port.mutex);
retval = block_til_ready(tty, filp, info);
OpenPOWER on IntegriCloud