summaryrefslogtreecommitdiffstats
path: root/drivers/char/n_hdlc.c
diff options
context:
space:
mode:
authorAdrian Bunk <bunk@kernel.org>2007-10-16 23:29:25 -0700
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-10-17 08:42:55 -0700
commit827afdf093cce59bbbf9dc9f1c2eab86e2232b9e (patch)
tree287510107cb816eb7529da88f961a4b49ffe673d /drivers/char/n_hdlc.c
parentcba4fbbff2e9722e93b28e18fa7714b9013cbdda (diff)
downloadop-kernel-dev-827afdf093cce59bbbf9dc9f1c2eab86e2232b9e.zip
op-kernel-dev-827afdf093cce59bbbf9dc9f1c2eab86e2232b9e.tar.gz
n_hdlc.c: fix check-after-use
The Coverity checker spotted that we'd have already oops'ed if "tty" was NULL. Since "tty" can't be NULL when we reach this line of code this patch removes the NULL check. Signed-off-by: Adrian Bunk <bunk@kernel.org> Acked-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/n_hdlc.c')
-rw-r--r--drivers/char/n_hdlc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/n_hdlc.c b/drivers/char/n_hdlc.c
index e8332f3..82bcfb9 100644
--- a/drivers/char/n_hdlc.c
+++ b/drivers/char/n_hdlc.c
@@ -229,7 +229,7 @@ static void n_hdlc_release(struct n_hdlc *n_hdlc)
wake_up_interruptible (&tty->read_wait);
wake_up_interruptible (&tty->write_wait);
- if (tty != NULL && tty->disc_data == n_hdlc)
+ if (tty->disc_data == n_hdlc)
tty->disc_data = NULL; /* Break the tty->n_hdlc link */
/* Release transmit and receive buffers */
OpenPOWER on IntegriCloud