summaryrefslogtreecommitdiffstats
path: root/drivers/char/hw_random
diff options
context:
space:
mode:
authorChristian Borntraeger <borntraeger@de.ibm.com>2009-04-23 16:42:59 +0930
committerLinus Torvalds <torvalds@linux-foundation.org>2009-04-24 13:28:30 -0700
commite5b89542ea18020961882228c26db3ba87f6e608 (patch)
treed304de3e207ab02d9e02f944f54cebcf31ea2e73 /drivers/char/hw_random
parent9f5a691253924fd033a58c6b1fed57bb0a4eccf4 (diff)
downloadop-kernel-dev-e5b89542ea18020961882228c26db3ba87f6e608.zip
op-kernel-dev-e5b89542ea18020961882228c26db3ba87f6e608.tar.gz
virtio-rng: Remove false BUG for spurious callbacks
The virtio-rng drivers checks for spurious callbacks. Since callbacks can be implemented via shared interrupts (e.g. PCI) this could lead to guest kernel oopses with lots of virtio devices. Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/hw_random')
-rw-r--r--drivers/char/hw_random/virtio-rng.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
index d0e563e..86e83f8 100644
--- a/drivers/char/hw_random/virtio-rng.c
+++ b/drivers/char/hw_random/virtio-rng.c
@@ -37,9 +37,9 @@ static void random_recv_done(struct virtqueue *vq)
{
int len;
- /* We never get spurious callbacks. */
+ /* We can get spurious callbacks, e.g. shared IRQs + virtio_pci. */
if (!vq->vq_ops->get_buf(vq, &len))
- BUG();
+ return;
data_left = len / sizeof(random_data[0]);
complete(&have_data);
OpenPOWER on IntegriCloud