diff options
| author | Julia Lawall <julia@diku.dk> | 2007-12-05 13:55:36 -0800 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2008-02-05 14:33:33 +1000 |
| commit | 91d361c279b66ce4d617d544641d5f70b27c401a (patch) | |
| tree | 9991f26bf4f2cbccc3b7f2d7ea30b6fe593f92da /drivers/char/agp | |
| parent | 62f29babbc60ab572d3cecda981931d3a66123d6 (diff) | |
| download | op-kernel-dev-91d361c279b66ce4d617d544641d5f70b27c401a.zip op-kernel-dev-91d361c279b66ce4d617d544641d5f70b27c401a.tar.gz | |
agp: remove unnecessary pci_dev_put
pci_get_class implicitly does a pci_dev_put on its second argument, so
pci_dev_put is only needed if there is a break out of the loop.
The semantic match detecting this problem is as follows:
// <smpl>
@@
expression dev;
expression E;
@@
* pci_dev_put(dev)
... when != dev = E
(
* pci_get_device(...,dev)
|
* pci_get_device_reverse(...,dev)
|
* pci_get_subsys(...,dev)
|
* pci_get_class(...,dev)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Airlie <airlied@linux.ie>
Diffstat (limited to 'drivers/char/agp')
| -rw-r--r-- | drivers/char/agp/amd-k7-agp.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c index 1405a42..87be464 100644 --- a/drivers/char/agp/amd-k7-agp.c +++ b/drivers/char/agp/amd-k7-agp.c @@ -436,10 +436,6 @@ static int __devinit agp_amdk7_probe(struct pci_dev *pdev, return -ENODEV; } cap_ptr = pci_find_capability(gfxcard, PCI_CAP_ID_AGP); - if (!cap_ptr) { - pci_dev_put(gfxcard); - continue; - } } /* With so many variants of NVidia cards, it's simpler just |
