summaryrefslogtreecommitdiffstats
path: root/drivers/bus
diff options
context:
space:
mode:
authorKeerthy <j-keerthy@ti.com>2014-11-10 23:49:48 +0530
committerTony Lindgren <tony@atomide.com>2014-11-12 07:16:27 -0800
commitc4cf0935a2d8fe6d186bf4253ea3c4b4a8a8a710 (patch)
tree7e8ef2f43c8ea1e16d5d935ed7d57feb8261cec8 /drivers/bus
parent61b43d4e919e8fa5e10c77ee32ba328da07e0264 (diff)
downloadop-kernel-dev-c4cf0935a2d8fe6d186bf4253ea3c4b4a8a8a710.zip
op-kernel-dev-c4cf0935a2d8fe6d186bf4253ea3c4b4a8a8a710.tar.gz
bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler
Correct returning IRQ_HANDLED unconditionally in the irq handler. Return IRQ_NONE for some interrupt which we do not expect to be handled in this handler. This prevents kernel stalling with back to back spurious interrupts. Fixes: 2722e56de6 ("OMAP4: l3: Introduce l3-interconnect error handling driver") Acked-by: Nishanth Menon <nm@ti.com> Signed-off-by: Keerthy <j-keerthy@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'drivers/bus')
-rw-r--r--drivers/bus/omap_l3_noc.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index b5eac29..17d8659 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
@@ -222,10 +222,14 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3)
}
/* Error found so break the for loop */
- break;
+ return IRQ_HANDLED;
}
}
- return IRQ_HANDLED;
+
+ dev_err(l3->dev, "L3 %s IRQ not handled!!\n",
+ inttype ? "debug" : "application");
+
+ return IRQ_NONE;
}
static const struct of_device_id l3_noc_match[] = {
OpenPOWER on IntegriCloud