summaryrefslogtreecommitdiffstats
path: root/drivers/bus
diff options
context:
space:
mode:
authorAndrzej Hajda <a.hajda@samsung.com>2016-02-23 10:49:44 +0000
committerWill Deacon <will.deacon@arm.com>2016-02-29 23:23:16 +0000
commit0f17380c1aae80fe0f2fa495cb627ba750b693de (patch)
treed2a2d19a38e3c2ffc2b9ded0417c3b075a571ca2 /drivers/bus
parent5e442eba342e567e2b3f1a39a24f81559f8370f7 (diff)
downloadop-kernel-dev-0f17380c1aae80fe0f2fa495cb627ba750b693de.zip
op-kernel-dev-0f17380c1aae80fe0f2fa495cb627ba750b693de.tar.gz
arm-cci: fix handling cpumask_any_but return value
cpumask_any_but returns value >= nr_cpu_ids if there are no more CPUs. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Acked-by: Olof Johansson <olof@lixom.net> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Acked-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'drivers/bus')
-rw-r--r--drivers/bus/arm-cci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index ee47e6b..5fb1c06 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1270,7 +1270,7 @@ static int cci_pmu_cpu_notifier(struct notifier_block *self,
if (!cpumask_test_and_clear_cpu(cpu, &cci_pmu->cpus))
break;
target = cpumask_any_but(cpu_online_mask, cpu);
- if (target < 0) // UP, last CPU
+ if (target >= nr_cpu_ids) // UP, last CPU
break;
/*
* TODO: migrate context once core races on event->ctx have
OpenPOWER on IntegriCloud