summaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorSagi Grimberg <sagi@grimberg.me>2017-07-04 09:57:09 +0300
committerSagi Grimberg <sagi@grimberg.me>2017-07-06 09:49:05 +0300
commitb52c2e92546ee794a5bbab4d8ea435c1de85a8cb (patch)
tree1c08c453408a45a247e6a23204e39aa7f318c9c2 /drivers/block
parent8d7b8fafad87c3404f72ce2d36c79c48be1129a6 (diff)
downloadop-kernel-dev-b52c2e92546ee794a5bbab4d8ea435c1de85a8cb.zip
op-kernel-dev-b52c2e92546ee794a5bbab4d8ea435c1de85a8cb.tar.gz
nbd: quiesce request queues to make sure no submissions are inflight
Unlike blk_mq_stop_hw_queues, blk_mq_quiesce_queue respects the submission path rcu grace. quiesce the queue before iterating on live tags. Reviewed-by: Ming Lei <ming.lei@redhat.com> Acked-by: Josef Bacik <jbacik@fb.com> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/nbd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 977ec96..dea7d85 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -661,9 +661,9 @@ static void nbd_clear_req(struct request *req, void *data, bool reserved)
static void nbd_clear_que(struct nbd_device *nbd)
{
- blk_mq_stop_hw_queues(nbd->disk->queue);
+ blk_mq_quiesce_queue(nbd->disk->queue);
blk_mq_tagset_busy_iter(&nbd->tag_set, nbd_clear_req, NULL);
- blk_mq_start_hw_queues(nbd->disk->queue);
+ blk_mq_unquiesce_queue(nbd->disk->queue);
dev_dbg(disk_to_dev(nbd->disk), "queue cleared\n");
}
OpenPOWER on IntegriCloud