summaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-12-27 22:27:11 +0100
committerPhilipp Reisner <philipp.reisner@linbit.com>2010-01-04 11:51:41 +0100
commit2d1ee87d8763b38668f6f11bb53abb689a49a43e (patch)
tree3a87ab8e3339a64d5f4c13938e1234f0b07a19dd /drivers/block
parentc1152949bbdfddf8fc857a883294461d757d5332 (diff)
downloadop-kernel-dev-2d1ee87d8763b38668f6f11bb53abb689a49a43e.zip
op-kernel-dev-2d1ee87d8763b38668f6f11bb53abb689a49a43e.tar.gz
drivers/block/drbd: Correct NULL test
Test the just-allocated value for NULL rather than some other value. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y; statement S; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ( if ((x) == NULL) S | if ( - y + x == NULL) S ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/drbd/drbd_receiver.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index a6d266e..dbd4519 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -3945,7 +3945,7 @@ static int drbd_do_auth(struct drbd_conf *mdev)
}
right_response = kmalloc(resp_size, GFP_NOIO);
- if (response == NULL) {
+ if (right_response == NULL) {
dev_err(DEV, "kmalloc of right_response failed\n");
rv = 0;
goto fail;
OpenPOWER on IntegriCloud