diff options
author | Mike Snitzer <snitzer@redhat.com> | 2011-11-23 10:59:13 +0100 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2011-11-23 10:59:13 +0100 |
commit | 5151412dd4338b273afdb107c3772528e9e67d92 (patch) | |
tree | ce88b8d64d903cf99b2ee3f5c66af143d23b0bc6 /drivers/block | |
parent | b4bbb02934e4511d9083f15c23e90703482e84ad (diff) | |
download | op-kernel-dev-5151412dd4338b273afdb107c3772528e9e67d92.zip op-kernel-dev-5151412dd4338b273afdb107c3772528e9e67d92.tar.gz |
block: initialize request_queue's numa node during
struct request_queue is allocated with __GFP_ZERO so its "node" field is
zero before initialization. This causes an oops if node 0 is offline in
the page allocator because its zonelists are not initialized. From Dave
Young's dmesg:
SRAT: Node 1 PXM 2 0-d0000000
SRAT: Node 1 PXM 2 100000000-330000000
SRAT: Node 0 PXM 1 330000000-630000000
Initmem setup node 1 0000000000000000-000000000affb000
...
Built 1 zonelists in Node order, mobility grouping on.
...
BUG: unable to handle kernel paging request at 0000000000001c08
IP: [<ffffffff8111c355>] __alloc_pages_nodemask+0xb5/0x870
and __alloc_pages_nodemask+0xb5 translates to a NULL pointer on
zonelist->_zonerefs.
The fix is to initialize q->node at the time of allocation so the correct
node is passed to the slab allocator later.
Since blk_init_allocated_queue_node() is no longer needed, merge it with
blk_init_allocated_queue().
[rientjes@google.com: changelog, initializing q->node]
Cc: stable@vger.kernel.org [2.6.37+]
Reported-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Tested-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block')
0 files changed, 0 insertions, 0 deletions