diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-12-29 23:47:21 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2014-01-03 10:05:34 +0100 |
| commit | 8586ea96b4f919a9b38929040bc9ce57c9998fc4 (patch) | |
| tree | 41b2a3d534122e1074eaecea0c198b760f488de6 /drivers/block | |
| parent | 644ff181da10e053dad8fa3de07d1bed8ac0a23f (diff) | |
| download | op-kernel-dev-8586ea96b4f919a9b38929040bc9ce57c9998fc4.zip op-kernel-dev-8586ea96b4f919a9b38929040bc9ce57c9998fc4.tar.gz | |
pktcdvd: fix error return code
Set the return variable to an error code as done elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/pktcdvd.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index 3dda09a..a2af73d 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -706,7 +706,9 @@ static int pkt_generic_packet(struct pktcdvd_device *pd, struct packet_command * WRITE : READ, __GFP_WAIT); if (cgc->buflen) { - if (blk_rq_map_kern(q, rq, cgc->buffer, cgc->buflen, __GFP_WAIT)) + ret = blk_rq_map_kern(q, rq, cgc->buffer, cgc->buflen, + __GFP_WAIT); + if (ret) goto out; } |
