summaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorPeter Osterlund <petero2@telia.com>2005-05-16 21:53:42 -0700
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-05-17 07:59:18 -0700
commit7baeb6a5ccab2d472679a053e64a63ac423c3a42 (patch)
treebdc3f674c4d0d82c3e6695f453eeb641a0eea5e6 /drivers/block
parentd0856009dbaf8eca2269d4129bb83940c0d95054 (diff)
downloadop-kernel-dev-7baeb6a5ccab2d472679a053e64a63ac423c3a42.zip
op-kernel-dev-7baeb6a5ccab2d472679a053e64a63ac423c3a42.tar.gz
[PATCH] CDRW/DVD packet writing data corruption fix
I found a bug in the packet writing driver that could cause data corruption. The problem arised if the driver got a write request for a sector in a "zone" it was already working on. In that case it was supposed to queue the write request until it was done processing earlier requests for the same zone, and instead work on some other zone in the mean time. However, if there was no other zone to work on, the driver would initiate two packet_data objects for the same zone, causing unpredictable things to happen. Signed-off-by: Peter Osterlund <petero2@telia.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/pktcdvd.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 82ccad0..b9a6b7a 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -914,8 +914,10 @@ static int pkt_handle_queue(struct pktcdvd_device *pd)
bio = node->bio;
zone = ZONE(bio->bi_sector, pd);
list_for_each_entry(p, &pd->cdrw.pkt_active_list, list) {
- if (p->sector == zone)
+ if (p->sector == zone) {
+ bio = NULL;
goto try_next_bio;
+ }
}
break;
try_next_bio:
OpenPOWER on IntegriCloud