summaryrefslogtreecommitdiffstats
path: root/drivers/block/pktcdvd.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-05-16 11:11:08 +0300
committerJiri Kosina <jkosina@suse.cz>2013-05-29 15:36:22 +0200
commit104529661b645295903c5007ae632d2dd4029254 (patch)
treeab4242f743136c1545ce1b336311c5c656ce4274 /drivers/block/pktcdvd.c
parentf722406faae2d073cc1d01063d1123c35425939e (diff)
downloadop-kernel-dev-104529661b645295903c5007ae632d2dd4029254.zip
op-kernel-dev-104529661b645295903c5007ae632d2dd4029254.tar.gz
pktcdvd: silence static checker warning
Static checkers complain about widening the binary "not" operations here because sectors are u64 and "(pd)->settings.size" is unsigned int. It unintentionally clears the high 32 bits of the sector. This means that the driver won't work for devices with over 2TB of space. Since this is a DVD drive, we're unlikely to reach that limit, but we may as well silence the warning. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/block/pktcdvd.c')
-rw-r--r--drivers/block/pktcdvd.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 3c08983..f5d0ea1 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -83,7 +83,8 @@
#define MAX_SPEED 0xffff
-#define ZONE(sector, pd) (((sector) + (pd)->offset) & ~((pd)->settings.size - 1))
+#define ZONE(sector, pd) (((sector) + (pd)->offset) & \
+ ~(sector_t)((pd)->settings.size - 1))
static DEFINE_MUTEX(pktcdvd_mutex);
static struct pktcdvd_device *pkt_devs[MAX_WRITERS];
OpenPOWER on IntegriCloud