diff options
author | Lukas Wunner <lukas@wunner.de> | 2018-01-10 16:32:10 +0100 |
---|---|---|
committer | Marcel Holtmann <marcel@holtmann.org> | 2018-01-10 19:00:13 +0100 |
commit | 8bfa7e1e03aca3626b82857850a1e18ae0ed291d (patch) | |
tree | 5a9c893366926985757accf5fdcf5c034857164e /drivers/bcma | |
parent | 8353b4a636f2c83de748656acc6b6a8757d7a0ff (diff) | |
download | op-kernel-dev-8bfa7e1e03aca3626b82857850a1e18ae0ed291d.zip op-kernel-dev-8bfa7e1e03aca3626b82857850a1e18ae0ed291d.tar.gz |
Bluetooth: hci_bcm: Handle errors properly
A significant portion of this driver lacks error handling. As a first
step, add error paths to bcm_gpio_set_power(), bcm_open(), bcm_close(),
bcm_suspend_device(), bcm_resume_device(), bcm_resume(), bcm_probe() and
bcm_serdev_probe(). (I've also scrutinized bcm_suspend() but think it's
fine as is.)
Those are all the functions accessing the device wake and shutdown GPIO.
On Apple Macs the pins are accessed through ACPI methods, which may fail
for various reasons, hence proper error handling is necessary. Non-Macs
access the pins directly, which may fail as well but the GPIO core does
not yet pass back errors to consumers.
Cc: Frédéric Danis <frederic.danis.oss@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bcma')
0 files changed, 0 insertions, 0 deletions