summaryrefslogtreecommitdiffstats
path: root/drivers/base
diff options
context:
space:
mode:
authorJames Bottomley <James.Bottomley@HansenPartnership.com>2008-04-02 10:05:48 -0500
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2008-04-07 12:19:10 -0500
commit2f3edc6936e3f6be3f1df1e89c141ae028fa605e (patch)
tree14198ea135c600b42e4c7416db44967a6517a2db /drivers/base
parentfa8e36c39b00a219d2c37250e493c3421e0e67e9 (diff)
downloadop-kernel-dev-2f3edc6936e3f6be3f1df1e89c141ae028fa605e.zip
op-kernel-dev-2f3edc6936e3f6be3f1df1e89c141ae028fa605e.tar.gz
[SCSI] transport_class: BUG if we can't release the attribute container
Every current transport class calls transport_container_release but ignores the return value. This is catastrophic if it returns an error because the containers are part of a global list and the next action of almost every transport class is to free the memory used by the container. Fix this by making transport_container_release a void, but making it BUG if attribute_container_release returns an error ... this catches the root cause of a system panic much earlier. If we don't do this, we get an eventual BUG when the attribute container list notices the corruption caused by the freed memory it's still referencing. Also made attribute_container_release __must_check as a reminder. Cc: Greg KH <greg@kroah.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/transport_class.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/base/transport_class.c b/drivers/base/transport_class.c
index 40bca48..cabd0ed 100644
--- a/drivers/base/transport_class.c
+++ b/drivers/base/transport_class.c
@@ -108,7 +108,8 @@ EXPORT_SYMBOL_GPL(anon_transport_class_register);
*/
void anon_transport_class_unregister(struct anon_transport_class *atc)
{
- attribute_container_unregister(&atc->container);
+ if (unlikely(attribute_container_unregister(&atc->container)))
+ BUG();
}
EXPORT_SYMBOL_GPL(anon_transport_class_unregister);
OpenPOWER on IntegriCloud