diff options
| author | Krzysztof Kozlowski <k.kozlowski@samsung.com> | 2015-01-09 09:27:57 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-01-23 22:32:38 +0100 |
| commit | 04bf1c7f76b05be8134a833ec023f1c96f81b8a1 (patch) | |
| tree | 0963cc88a63e7201f1bf46125cfed519164f9e9e /drivers/base/power | |
| parent | 984f16c8490cba715444124a453ed4a2ac7a5a54 (diff) | |
| download | op-kernel-dev-04bf1c7f76b05be8134a833ec023f1c96f81b8a1.zip op-kernel-dev-04bf1c7f76b05be8134a833ec023f1c96f81b8a1.tar.gz | |
PM / OPP: Assert RCU lock in exported functions
Add lockdep asserts for holding the RCU lock when calling
dev_pm_opp_get_freq() and dev_pm_opp_get_voltage() to aid in detecting
RCU misuses.
These are called often after dev_pm_opp_find_freq_ceil/exact() which
already asserts for RCU lock. However one could make an error by
releasing lock too early - just after dev_pm_opp_find_freq_ceil().
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/base/power')
| -rw-r--r-- | drivers/base/power/opp.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 1d20e09..15bf299 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -169,6 +169,8 @@ unsigned long dev_pm_opp_get_voltage(struct dev_pm_opp *opp) struct dev_pm_opp *tmp_opp; unsigned long v = 0; + opp_rcu_lockdep_assert(); + tmp_opp = rcu_dereference(opp); if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available) pr_err("%s: Invalid parameters\n", __func__); @@ -199,6 +201,8 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) struct dev_pm_opp *tmp_opp; unsigned long f = 0; + opp_rcu_lockdep_assert(); + tmp_opp = rcu_dereference(opp); if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available) pr_err("%s: Invalid parameters\n", __func__); |
