summaryrefslogtreecommitdiffstats
path: root/drivers/atm
diff options
context:
space:
mode:
authorNicholas Mc Guire <hofrat@osadl.org>2015-06-08 21:16:28 +0200
committerDavid S. Miller <davem@davemloft.net>2015-06-08 15:48:45 -0700
commit684b4ac14f4306c877834a8daaf0f0665128eae4 (patch)
tree862a69c5b467eae81e7be34b8cd072592c0032a5 /drivers/atm
parent6da8253bdd3945b81377e4908d6d395a9956f8af (diff)
downloadop-kernel-dev-684b4ac14f4306c877834a8daaf0f0665128eae4.zip
op-kernel-dev-684b4ac14f4306c877834a8daaf0f0665128eae4.tar.gz
atm: use msecs_to_jiffies for conversions
API compliance scanning with coccinelle flagged: ./drivers/atm/iphase.c:2621:4-20: WARNING: timeout (50) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent which does not seem intended. Fixed up by converting the constant to jiffies with msecs_to_jiffies() As this driver was introduced in the early 2.3 series it is most likely assuming HZ=100 so the constant 50 is converted to 500ms. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm')
-rw-r--r--drivers/atm/iphase.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 924f8e2..65e6590 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -2618,7 +2618,7 @@ static void ia_close(struct atm_vcc *vcc)
if (vcc->qos.txtp.traffic_class != ATM_NONE) {
iadev->close_pending++;
prepare_to_wait(&iadev->timeout_wait, &wait, TASK_UNINTERRUPTIBLE);
- schedule_timeout(50);
+ schedule_timeout(msecs_to_jiffies(500));
finish_wait(&iadev->timeout_wait, &wait);
spin_lock_irqsave(&iadev->tx_lock, flags);
while((skb = skb_dequeue(&iadev->tx_backlog))) {
OpenPOWER on IntegriCloud