diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-08-07 15:31:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-08-07 16:02:57 -0700 |
| commit | e5a98fc25a4f688f01b073d9fe0bbccc7807ab8e (patch) | |
| tree | 45f317393d4b8beedde67821b5781672dfb4f5c8 /drivers/atm | |
| parent | 0a4dd0d7868aa8e8b84a5d4ddb50fa0391709b5f (diff) | |
| download | op-kernel-dev-e5a98fc25a4f688f01b073d9fe0bbccc7807ab8e.zip op-kernel-dev-e5a98fc25a4f688f01b073d9fe0bbccc7807ab8e.tar.gz | |
drivers/atm/atmtcp.c: fix error return code
Convert a zero return value on error to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm')
| -rw-r--r-- | drivers/atm/atmtcp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/atm/atmtcp.c b/drivers/atm/atmtcp.c index 0e3f8f9..480fa6f 100644 --- a/drivers/atm/atmtcp.c +++ b/drivers/atm/atmtcp.c @@ -299,6 +299,7 @@ static int atmtcp_c_send(struct atm_vcc *vcc,struct sk_buff *skb) out_vcc = find_vcc(dev, ntohs(hdr->vpi), ntohs(hdr->vci)); read_unlock(&vcc_sklist_lock); if (!out_vcc) { + result = -EUNATCH; atomic_inc(&vcc->stats->tx_err); goto done; } |
