diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-05-11 15:42:08 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2016-05-12 12:04:13 -0400 |
| commit | 7598469a6184e1017a77ebe78b5b66c52a6afc1c (patch) | |
| tree | 7bd15507e6c83305e9ac566f1c4cd3fc19b0ebf6 /drivers/ata | |
| parent | 951b8e4e673196932fa4c3b87d719644636e5ac9 (diff) | |
| download | op-kernel-dev-7598469a6184e1017a77ebe78b5b66c52a6afc1c.zip op-kernel-dev-7598469a6184e1017a77ebe78b5b66c52a6afc1c.tar.gz | |
ata: dwc: add DMADEVICES dependency
The dwc_460ex SATA driver has become available on non-powerpc architectures
and may cause randconfig build errors when CONFIG_DMADEVICES is not set
and SATA_DWC_OLD_DMA is enabled:
warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!
This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we
cannot run into broken configurations. While it would also be
possible to build the driver with both CONFIG_DMADEVICES
and SATA_DWC_OLD_DMA disabled, that case is not useful because
there is no fallback to PIO mode when the DMA engine is not
usable.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 3f9bbbf..2fbf355 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -305,6 +305,7 @@ config ATA_PIIX config SATA_DWC tristate "DesignWare Cores SATA support" + depends on DMADEVICES select GENERIC_PHY help This option enables support for the on-chip SATA controller of the |
