summaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2009-01-25 10:26:00 +0900
committerJeff Garzik <jgarzik@redhat.com>2009-01-26 06:36:26 -0500
commitb919930c34e99a48d6b13a5ec9db8c059ec44d72 (patch)
tree09c5b53cac420a4fa2509ca970f8c80b7c9fbb80 /drivers/ata
parent80ee6f54f51ffc623843dd8955248d4fab064b99 (diff)
downloadop-kernel-dev-b919930c34e99a48d6b13a5ec9db8c059ec44d72.zip
op-kernel-dev-b919930c34e99a48d6b13a5ec9db8c059ec44d72.tar.gz
libata: set NODEV_HINT for 0x7f status
Asus Pundit-R with atiixp controller has the second port missing and, very unusually, its status is stuck at 0x7f and all others at 0. This meanst that it fails TF access test but gets detected as a disk due to classification code check and then evades polling IDENTIFY presence detection thanks to the missing BSY in the status value causing excessive delays during boot. This patch makes libata-sff HSM set NODEV_HINT if the status is 0x7f to make polling IDENTIFY presence detection work for these machines. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/libata-sff.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 0a8567c..0b299b0 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1358,6 +1358,16 @@ fsm_start:
qc->err_mask |= AC_ERR_HSM;
}
+ /* There are oddball controllers with
+ * status register stuck at 0x7f and
+ * lbal/m/h at zero which makes it
+ * pass all other presence detection
+ * mechanisms we have. Set NODEV_HINT
+ * for it. Kernel bz#7241.
+ */
+ if (status == 0x7f)
+ qc->err_mask |= AC_ERR_NODEV_HINT;
+
/* ata_pio_sectors() might change the
* state to HSM_ST_LAST. so, the state
* is changed after ata_pio_sectors().
OpenPOWER on IntegriCloud