diff options
| author | Tejun Heo <htejun@gmail.com> | 2007-01-27 11:04:26 +0900 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-01-27 02:50:36 -0500 |
| commit | a718728f9e40ec79c0879ec6509a54fee214f5b2 (patch) | |
| tree | 547885a7f46380d10c6ebdcf16cac96d36d6991d /drivers/ata | |
| parent | 7d620a4e531ae4d432d3c88f7d4b75327d881a87 (diff) | |
| download | op-kernel-dev-a718728f9e40ec79c0879ec6509a54fee214f5b2.zip op-kernel-dev-a718728f9e40ec79c0879ec6509a54fee214f5b2.tar.gz | |
ahci: port_no should be used when clearing IRQ in ahci_thaw()
ap->id is logcial port ID which is unique among all ATA ports and
doesn't have anything to do with hardware port index. ap->port_no is
the hardware port index and thus should be used when clearing IRQ mask
in ahci_thaw().
This problem has been spotted by Jeff Garzik <jgarzik@pobox.com>.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/ahci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 28a82e3..48616c6 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1282,7 +1282,7 @@ static void ahci_thaw(struct ata_port *ap) /* clear IRQ */ tmp = readl(port_mmio + PORT_IRQ_STAT); writel(tmp, port_mmio + PORT_IRQ_STAT); - writel(1 << ap->id, mmio + HOST_IRQ_STAT); + writel(1 << ap->port_no, mmio + HOST_IRQ_STAT); /* turn IRQ back on */ writel(DEF_PORT_IRQ, port_mmio + PORT_IRQ_MASK); |
