diff options
| author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2009-02-17 14:00:50 -0700 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2009-03-17 01:52:40 -0400 |
| commit | 6eca4b4ca168981d7648be371945c2a21f463a45 (patch) | |
| tree | e47781d335040778c5acb4e9513f2b27cee43fb2 /drivers/acpi/pci_link.c | |
| parent | c9d6244329c8149312dba27e78dc4a83b35a6ae5 (diff) | |
| download | op-kernel-dev-6eca4b4ca168981d7648be371945c2a21f463a45.zip op-kernel-dev-6eca4b4ca168981d7648be371945c2a21f463a45.tar.gz | |
ACPI: pci_link: remove unnecessary null pointer checks
Better to oops and learn about a bug than to silently cover it up.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/pci_link.c')
| -rw-r--r-- | drivers/acpi/pci_link.c | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index b59f59e..dd9ebb9 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@ -179,9 +179,6 @@ static int acpi_pci_link_get_possible(struct acpi_pci_link *link) { acpi_status status; - if (!link) - return -EINVAL; - status = acpi_walk_resources(link->device->handle, METHOD_NAME__PRS, acpi_pci_link_check_possible, link); if (ACPI_FAILURE(status)) { @@ -259,9 +256,6 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link) acpi_status status; int irq = 0; - if (!link) - return -EINVAL; - link->irq.active = 0; /* in practice, status disabled is meaningless, ignore it */ @@ -314,7 +308,7 @@ static int acpi_pci_link_set(struct acpi_pci_link *link, int irq) } *resource; struct acpi_buffer buffer = { 0, NULL }; - if (!link || !irq) + if (!irq) return -EINVAL; resource = kzalloc(sizeof(*resource) + 1, irqs_disabled() ? GFP_ATOMIC: GFP_KERNEL); @@ -712,9 +706,6 @@ static int acpi_pci_link_add(struct acpi_device *device) int i; int found = 0; - if (!device) - return -EINVAL; - link = kzalloc(sizeof(struct acpi_pci_link), GFP_KERNEL); if (!link) return -ENOMEM; @@ -795,9 +786,6 @@ static int acpi_pci_link_remove(struct acpi_device *device, int type) { struct acpi_pci_link *link; - if (!device || !acpi_driver_data(device)) - return -EINVAL; - link = acpi_driver_data(device); mutex_lock(&acpi_link_lock); |
