summaryrefslogtreecommitdiffstats
path: root/drivers/acpi/apei/erst.c
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2013-07-02 09:02:32 +0800
committerTony Luck <tony.luck@intel.com>2013-08-19 10:13:30 -0700
commit08b326d071534fe5f122d8dec373cacb40bc7a7b (patch)
treee5b6165bf1c5d88ffa10ff303a142497611bbba1 /drivers/acpi/apei/erst.c
parentb36f4be3de1b123d8601de062e7dbfc904f305fb (diff)
downloadop-kernel-dev-08b326d071534fe5f122d8dec373cacb40bc7a7b.zip
op-kernel-dev-08b326d071534fe5f122d8dec373cacb40bc7a7b.tar.gz
acpi/apei/erst: Add missing iounmap() on error in erst_exec_move_data()
Add the missing iounmap() before return from erst_exec_move_data() in the error handling case. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'drivers/acpi/apei/erst.c')
-rw-r--r--drivers/acpi/apei/erst.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index 88d0b0f..6885809 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -284,8 +284,10 @@ static int erst_exec_move_data(struct apei_exec_context *ctx,
if (!src)
return -ENOMEM;
dst = ioremap(ctx->dst_base + offset, ctx->var2);
- if (!dst)
+ if (!dst) {
+ iounmap(src);
return -ENOMEM;
+ }
memmove(dst, src, ctx->var2);
OpenPOWER on IntegriCloud