summaryrefslogtreecommitdiffstats
path: root/drivers/acpi/acpica
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2011-01-20 16:21:59 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2011-01-20 16:21:59 -0800
commit28e58ee8ce1f0e69c207f747b7b9054b071e328d (patch)
treeb9191d7e213ad6e8ceb43d45e3306ced085b04f7 /drivers/acpi/acpica
parentd7b9935a347ae954be907ea3d5eb4564ff124c53 (diff)
downloadop-kernel-dev-28e58ee8ce1f0e69c207f747b7b9054b071e328d.zip
op-kernel-dev-28e58ee8ce1f0e69c207f747b7b9054b071e328d.tar.gz
Fix broken "pipe: use event aware wakeups" optimization
Commit e462c448fdc8 ("pipe: use event aware wakeups") optimized the pipe event wakeup calls to avoid wakeups if the events do not match the requested set. However, the optimization was buggy, in that it didn't actually use the correct sets for the events: when we make room for more data to be written, the pipe poll() routine will return both the POLLOUT _and_ POLLWRNORM bits. Similarly for read. And most critically, when a pipe is released, that will potentially result in POLLHUP|POLLERR (depending on whether it was the last reader or writer), not just the regular POLLIN|POLLOUT. This bug showed itself as a hung gnome-screensaver-dialog process, stuck forever (or at least until it was poked by a signal or by being traced) in a poll() system call. Cc: Davide Libenzi <davidel@xmailserver.org> Cc: David S. Miller <davem@davemloft.net> Cc: Eric Dumazet <eric.dumazet@gmail.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/acpi/acpica')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud