summaryrefslogtreecommitdiffstats
path: root/drivers/acpi/acpi_dbg.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-12-24 10:23:03 +0300
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2015-12-28 01:29:40 +0100
commit436db5ce0d0e892d2f7327dd7ffd573c5fb9e6cb (patch)
treeba2aded9eacd34d75e92ee2b48ec408c417bb64d /drivers/acpi/acpi_dbg.c
parent73af2d590ab1b7bc7c3fc3e6933d5dcd379c9c2e (diff)
downloadop-kernel-dev-436db5ce0d0e892d2f7327dd7ffd573c5fb9e6cb.zip
op-kernel-dev-436db5ce0d0e892d2f7327dd7ffd573c5fb9e6cb.tar.gz
ACPI / debugger: remove some unneeded conditions
"count" is unsigned so checking for less than zero here causes a static checker warning. And really it's better to let the access_ok() check fail if the user passes in a NULL "buf" pointer because -EFAULT is the correct error code. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/acpi_dbg.c')
-rw-r--r--drivers/acpi/acpi_dbg.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c
index fa18bd0..975ccec 100644
--- a/drivers/acpi/acpi_dbg.c
+++ b/drivers/acpi/acpi_dbg.c
@@ -610,8 +610,6 @@ static ssize_t acpi_aml_read(struct file *file, char __user *buf,
int ret = 0;
int size = 0;
- if (!buf || count < 0)
- return -EINVAL;
if (!count)
return 0;
if (!access_ok(VERIFY_WRITE, buf, count))
@@ -681,8 +679,6 @@ static ssize_t acpi_aml_write(struct file *file, const char __user *buf,
int ret = 0;
int size = 0;
- if (!buf || count < 0)
- return -EINVAL;
if (!count)
return 0;
if (!access_ok(VERIFY_READ, buf, count))
OpenPOWER on IntegriCloud