summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2016-12-13 09:26:18 +0000
committerHerbert Xu <herbert@gondor.apana.org.au>2016-12-14 18:33:13 +0800
commitfbb726302a9ae06b373e04a54ad30eafa288dd10 (patch)
treedbb7b338e7e26073ec1d1bc25731f8b39595a8c3 /crypto
parent04b46fbdea5e31ffd745a34fa61269a69ba9f47a (diff)
downloadop-kernel-dev-fbb726302a9ae06b373e04a54ad30eafa288dd10.zip
op-kernel-dev-fbb726302a9ae06b373e04a54ad30eafa288dd10.tar.gz
crypto: asymmetric_keys - set error code on failure
In function public_key_verify_signature(), returns variable ret on error paths. When the call to kmalloc() fails, the value of ret is 0, and it is not set to an errno before returning. This patch fixes the bug. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891 Signed-off-by: Pan Bian <bianpan2016@163.com> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/asymmetric_keys/public_key.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
index fd76b5f..d3a989e 100644
--- a/crypto/asymmetric_keys/public_key.c
+++ b/crypto/asymmetric_keys/public_key.c
@@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
if (ret)
goto error_free_req;
+ ret = -ENOMEM;
outlen = crypto_akcipher_maxsize(tfm);
output = kmalloc(outlen, GFP_KERNEL);
if (!output)
OpenPOWER on IntegriCloud