summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorAdrian-Ken Rueegsegger <rueegsegger@swiss-it.ch>2009-02-05 16:19:31 +1100
committerHerbert Xu <herbert@gondor.apana.org.au>2009-02-05 16:19:31 +1100
commit4abfd73e34e7915e62b6f75bd3e9f4014f830910 (patch)
treec22b49cfe64dbb065df97eb4dc1e9e437bdafbb6 /crypto
parentb8e15992b420d09dae831125a623c474c8637cee (diff)
downloadop-kernel-dev-4abfd73e34e7915e62b6f75bd3e9f4014f830910.zip
op-kernel-dev-4abfd73e34e7915e62b6f75bd3e9f4014f830910.tar.gz
crypto: shash - Fix module refcount
Module reference counting for shash is incorrect: when a new shash transformation is created the refcount is not increased as it should. Signed-off-by: Adrian-Ken Rueegsegger <rueegsegger@swiss-it.ch> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/shash.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/crypto/shash.c b/crypto/shash.c
index c9df367..d5a2b61 100644
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -388,10 +388,15 @@ static int crypto_init_shash_ops_compat(struct crypto_tfm *tfm)
struct shash_desc *desc = crypto_tfm_ctx(tfm);
struct crypto_shash *shash;
+ if (!crypto_mod_get(calg))
+ return -EAGAIN;
+
shash = __crypto_shash_cast(crypto_create_tfm(
calg, &crypto_shash_type));
- if (IS_ERR(shash))
+ if (IS_ERR(shash)) {
+ crypto_mod_put(calg);
return PTR_ERR(shash);
+ }
desc->tfm = shash;
tfm->exit = crypto_exit_shash_ops_compat;
OpenPOWER on IntegriCloud