diff options
| author | Rabin Vincent <rabin.vincent@axis.com> | 2015-01-09 16:25:28 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2015-01-13 22:30:44 +1100 |
| commit | 8a45ac12ec5b6ee67f8559c78ae11d9af8b821ee (patch) | |
| tree | 6e3930b39740e7070c50dc62101340a3e634175c /crypto/tcrypt.c | |
| parent | 8155330aad477c5b1337895a6922df76817f0874 (diff) | |
| download | op-kernel-dev-8a45ac12ec5b6ee67f8559c78ae11d9af8b821ee.zip op-kernel-dev-8a45ac12ec5b6ee67f8559c78ae11d9af8b821ee.tar.gz | |
crypto: testmgr - don't use interruptible wait in tests
tcrypt/testmgr uses wait_for_completion_interruptible() everywhere when
it waits for a request to be completed. If it's interrupted, then the
test is aborted and the request is freed.
However, if any of these calls actually do get interrupted, the result
will likely be a kernel crash, when the driver handles the now-freed
request. Use wait_for_completion() instead.
Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/tcrypt.c')
| -rw-r--r-- | crypto/tcrypt.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 1d864e9..0043495 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -764,10 +764,9 @@ static inline int do_one_ahash_op(struct ahash_request *req, int ret) if (ret == -EINPROGRESS || ret == -EBUSY) { struct tcrypt_result *tr = req->base.data; - ret = wait_for_completion_interruptible(&tr->completion); - if (!ret) - ret = tr->err; + wait_for_completion(&tr->completion); reinit_completion(&tr->completion); + ret = tr->err; } return ret; } @@ -993,10 +992,9 @@ static inline int do_one_acipher_op(struct ablkcipher_request *req, int ret) if (ret == -EINPROGRESS || ret == -EBUSY) { struct tcrypt_result *tr = req->base.data; - ret = wait_for_completion_interruptible(&tr->completion); - if (!ret) - ret = tr->err; + wait_for_completion(&tr->completion); reinit_completion(&tr->completion); + ret = tr->err; } return ret; |
