summaryrefslogtreecommitdiffstats
path: root/crypto/digest.c
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2008-07-07 20:23:56 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2008-07-10 20:35:17 +0800
commitca786dc738f4f583b57b1bba7a335b5e8233f4b0 (patch)
treee2e6178fac1d9b3ac2b557cac76977e15f7d5d2c /crypto/digest.c
parentcaee16883a235b1b042282276859e7d5901fad21 (diff)
downloadop-kernel-dev-ca786dc738f4f583b57b1bba7a335b5e8233f4b0.zip
op-kernel-dev-ca786dc738f4f583b57b1bba7a335b5e8233f4b0.tar.gz
crypto: hash - Fixed digest size check
The digest size check on hash algorithms is incorrect. It's perfectly valid for hash algorithms to have a digest length longer than their block size. For example crc32c has a block size of 1 and a digest size of 4. Rather than having it lie about its block size, this patch fixes the checks to do what they really should which is to bound the digest size so that code placing the digest on the stack continue to work. HMAC however still needs to check this as it's only defined for such algorithms. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/digest.c')
-rw-r--r--crypto/digest.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/digest.c b/crypto/digest.c
index 025c9ae..d63d5d9 100644
--- a/crypto/digest.c
+++ b/crypto/digest.c
@@ -141,7 +141,7 @@ int crypto_init_digest_ops(struct crypto_tfm *tfm)
struct hash_tfm *ops = &tfm->crt_hash;
struct digest_alg *dalg = &tfm->__crt_alg->cra_digest;
- if (dalg->dia_digestsize > crypto_tfm_alg_blocksize(tfm))
+ if (dalg->dia_digestsize > PAGE_SIZE / 8)
return -EINVAL;
ops->init = init;
OpenPOWER on IntegriCloud