diff options
author | Stephan Mueller <smueller@chronox.de> | 2016-12-05 15:26:19 +0100 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2016-12-07 19:55:36 +0800 |
commit | 0c1e16cd1ec41987cc6671a2bff46ac958c41eb5 (patch) | |
tree | 45dfa74c15b77ad815e8ac60bd92b23d8a7adc03 /block | |
parent | 39eaf759466f4e3fbeaa39075512f4f345dffdc8 (diff) | |
download | op-kernel-dev-0c1e16cd1ec41987cc6671a2bff46ac958c41eb5.zip op-kernel-dev-0c1e16cd1ec41987cc6671a2bff46ac958c41eb5.tar.gz |
crypto: algif_aead - fix AEAD tag memory handling
For encryption, the AEAD ciphers require AAD || PT as input and generate
AAD || CT || Tag as output and vice versa for decryption. Prior to this
patch, the AF_ALG interface for AEAD ciphers requires the buffer to be
present as input for encryption. Similarly, the output buffer for
decryption required the presence of the tag buffer too. This implies
that the kernel reads / writes data buffers from/to kernel space
even though this operation is not required.
This patch changes the AF_ALG AEAD interface to be consistent with the
in-kernel AEAD cipher requirements.
Due to this handling, he changes are transparent to user space with one
exception: the return code of recv indicates the mount of output buffer.
That output buffer has a different size compared to before the patch
which implies that the return code of recv will also be different.
For example, a decryption operation uses 16 bytes AAD, 16 bytes CT and
16 bytes tag, the AF_ALG AEAD interface before showed a recv return
code of 48 (bytes) whereas after this patch, the return code is 32
since the tag is not returned any more.
Reported-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions