summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorJens Axboe <jens.axboe@oracle.com>2009-05-19 19:52:35 +0200
committerJens Axboe <jens.axboe@oracle.com>2009-05-19 19:52:35 +0200
commit53674ac5a997a8eedbb2dfdc308b895170746c8b (patch)
tree69fb2c7c2d9726e0ff3a8bc491b5bf1fc5e2d1d4 /block
parenta411f4bbb89f1f08687b344064d6775bce1e4658 (diff)
downloadop-kernel-dev-53674ac5a997a8eedbb2dfdc308b895170746c8b.zip
op-kernel-dev-53674ac5a997a8eedbb2dfdc308b895170746c8b.tar.gz
block: add warning to blk_make_request()
Add a note about how one needs to be careful when setting up these bio chains. Extracted from Boaz's updated patch. Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r--block/blk-core.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/block/blk-core.c b/block/blk-core.c
index bec1d69..4906507 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -910,6 +910,15 @@ EXPORT_SYMBOL(blk_get_request);
* need bouncing, by calling the appropriate masked or flagged allocator,
* suitable for the target device. Otherwise the call to blk_queue_bounce will
* BUG.
+ *
+ * WARNING: When allocating/cloning a bio-chain, careful consideration should be
+ * given to how you allocate bios. In particular, you cannot use __GFP_WAIT for
+ * anything but the first bio in the chain. Otherwise you risk waiting for IO
+ * completion of a bio that hasn't been submitted yet, thus resulting in a
+ * deadlock. Alternatively bios should be allocated using bio_kmalloc() instead
+ * of bio_alloc(), as that avoids the mempool deadlock.
+ * If possible a big IO should be split into smaller parts when allocation
+ * fails. Partial allocation should not be an error, or you risk a live-lock.
*/
struct request *blk_make_request(struct request_queue *q, struct bio *bio,
gfp_t gfp_mask)
OpenPOWER on IntegriCloud