diff options
| author | Davidlohr Bueso <davidlohr@hp.com> | 2013-09-11 14:24:57 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-11 15:59:16 -0700 |
| commit | 3e69ac344007bec5e3987ac86619e140fbc79b72 (patch) | |
| tree | bbaf03e104edb90d68c45453abbc4e7f48a7b899 /block/partitions/efi.c | |
| parent | 33afd7a7df1a1f82675857a75572cdf4a8599e9f (diff) | |
| download | op-kernel-dev-3e69ac344007bec5e3987ac86619e140fbc79b72.zip op-kernel-dev-3e69ac344007bec5e3987ac86619e140fbc79b72.tar.gz | |
partitions/efi: do not require gpt partition to begin at sector 1
When detecting a valid protective MBR, the Linux kernel isn't picky about
the partition (1-4) the 0xEE is at, but, unlike other operating systems,
it does require it to begin at the second sector (sector 1). This check,
apart from it not being enforced by UEFI, and causing Linux to potentially
fail to detect any *valid* partitions on the disk, can present problems
when dealing with hybrid MBRs[1].
For compatibility reasons, if the first partition is hybridized, the 0xEE
partition must be small enough to ensure that it only protects the GPT
data structures - as opposed to the the whole disk in a protective MBR.
This problem is very well described by Rod Smith[1]: where MBR-only
partitioning programs (such as older versions of fdisk) can see some of
the disk space as unallocated, thus loosing the purpose of the 0xEE
partition's protection of GPT data structures.
By dropping this check, this patch enables Linux to be more flexible when
probing for GPT disklabels.
[1] http://www.rodsbooks.com/gdisk/hybrid.html#reactions
Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
Reviewed-by: Karel Zak <kzak@redhat.com>
Acked-by: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'block/partitions/efi.c')
| -rw-r--r-- | block/partitions/efi.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/block/partitions/efi.c b/block/partitions/efi.c index 7a2b74f..1b499dc 100644 --- a/block/partitions/efi.c +++ b/block/partitions/efi.c @@ -158,9 +158,6 @@ static inline int pmbr_part_valid(gpt_mbr_record *part) if (le32_to_cpu(part->starting_lba) != GPT_PRIMARY_PARTITION_TABLE_LBA) goto invalid; - if (le32_to_cpu(part->start_sector) != 1UL) - goto invalid; - return 1; invalid: return 0; |
