summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorHaavard Skinnemoen <hskinnemoen@atmel.com>2008-01-24 16:56:53 +0100
committerHaavard Skinnemoen <hskinnemoen@atmel.com>2008-01-25 08:31:44 +0100
commitd6c49a7a78fc841418bbd58bda504076f80ec51d (patch)
treedb039655c3a4507047e17dc562defb546dbb9f50 /arch
parente4f586f280bbfa05c68f99df2db981356ee30533 (diff)
downloadop-kernel-dev-d6c49a7a78fc841418bbd58bda504076f80ec51d.zip
op-kernel-dev-d6c49a7a78fc841418bbd58bda504076f80ec51d.tar.gz
[AVR32] extint: Set initial irq type to low level
David Brownell pointed out a mismatch in the avr32 extint code: > I noticed a small glitch that's not fixed by this patch: the > initial type is falling edge, but IRQ_TYPE_NONE is mapped to > IRQ_TYPE_LEVEL_LOW. Potentially surprising. Fix it by setting the initial type (and handler) to low level, matching the meaning of IRQ_TYPE_NONE. Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/avr32/mach-at32ap/extint.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/avr32/mach-at32ap/extint.c b/arch/avr32/mach-at32ap/extint.c
index 81a4a02..c36a6d5 100644
--- a/arch/avr32/mach-at32ap/extint.c
+++ b/arch/avr32/mach-at32ap/extint.c
@@ -226,15 +226,15 @@ static int __init eic_probe(struct platform_device *pdev)
pattern = eic_readl(eic, MODE);
nr_irqs = fls(pattern);
- /* Trigger on falling edge unless overridden by driver */
- eic_writel(eic, MODE, 0UL);
+ /* Trigger on low level unless overridden by driver */
eic_writel(eic, EDGE, 0UL);
+ eic_writel(eic, LEVEL, 0UL);
eic->chip = &eic_chip;
for (i = 0; i < nr_irqs; i++) {
set_irq_chip_and_handler(eic->first_irq + i, &eic_chip,
- handle_edge_irq);
+ handle_level_irq);
set_irq_chip_data(eic->first_irq + i, eic);
}
OpenPOWER on IntegriCloud