summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>2007-03-26 09:38:42 +0900
committerTony Luck <tony.luck@intel.com>2007-03-29 15:02:58 -0700
commit8a3a0ee736b9a0150c9d894f2c6cc836a62125a1 (patch)
treefb98ffc7f346bead619a31c08012234131bee7c9 /arch
parenta76c0b976310bbb1b6eaecaaae465af194134477 (diff)
downloadop-kernel-dev-8a3a0ee736b9a0150c9d894f2c6cc836a62125a1.zip
op-kernel-dev-8a3a0ee736b9a0150c9d894f2c6cc836a62125a1.tar.gz
[IA64] Fix possible invalid memory access in ia64_setup_msi_irq()
The following 'if' statement in ia64_setup_msi_irq() always fails even if create_irq() returns <0 value, because variable 'irq' is defined as unsigned int. It would cause invalid memory access. irq = create_irq(); if (irq < 0) return irq; Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/ia64/kernel/msi_ia64.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ia64/kernel/msi_ia64.c b/arch/ia64/kernel/msi_ia64.c
index e722090..ebbeadf 100644
--- a/arch/ia64/kernel/msi_ia64.c
+++ b/arch/ia64/kernel/msi_ia64.c
@@ -68,7 +68,7 @@ int ia64_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc)
{
struct msi_msg msg;
unsigned long dest_phys_id;
- unsigned int irq, vector;
+ int irq, vector;
irq = create_irq();
if (irq < 0)
OpenPOWER on IntegriCloud