summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorstephane eranian <eranian@googlemail.com>2008-06-11 15:24:13 -0700
committerTony Luck <tony.luck@intel.com>2008-06-11 15:24:13 -0700
commit83014699b06fb9a300d896c7c49fb8be1c6c5ddc (patch)
tree6a0d75c35b278ab8e249cc396ef5bf222b4cd8ec /arch
parent28ffb5d3e0b563be5a9639c3a2b42f1a9430454f (diff)
downloadop-kernel-dev-83014699b06fb9a300d896c7c49fb8be1c6c5ddc.zip
op-kernel-dev-83014699b06fb9a300d896c7c49fb8be1c6c5ddc.tar.gz
[IA64] perfmon: fix async exit bug
Move the cleanup of the async queue to the close callback from the flush callback. This avoids losing asynchronous overflow notifications when the file descriptor is shared by multiple processes and one terminates. Signed-off-by: Stephane Eranian <eranian@gmail.com> Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/ia64/kernel/perfmon.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c
index 71d0513..7714a97 100644
--- a/arch/ia64/kernel/perfmon.c
+++ b/arch/ia64/kernel/perfmon.c
@@ -1864,11 +1864,6 @@ pfm_flush(struct file *filp, fl_owner_t id)
* invoked after, it will find an empty queue and no
* signal will be sent. In both case, we are safe
*/
- if (filp->f_flags & FASYNC) {
- DPRINT(("cleaning up async_queue=%p\n", ctx->ctx_async_queue));
- pfm_do_fasync (-1, filp, ctx, 0);
- }
-
PROTECT_CTX(ctx, flags);
state = ctx->ctx_state;
@@ -1999,6 +1994,11 @@ pfm_close(struct inode *inode, struct file *filp)
return -EBADF;
}
+ if (filp->f_flags & FASYNC) {
+ DPRINT(("cleaning up async_queue=%p\n", ctx->ctx_async_queue));
+ pfm_do_fasync(-1, filp, ctx, 0);
+ }
+
PROTECT_CTX(ctx, flags);
state = ctx->ctx_state;
OpenPOWER on IntegriCloud