summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorGuillaume Knispel <gknispel@proformatique.com>2008-12-09 15:28:34 +0100
committerKumar Gala <galak@kernel.crashing.org>2008-12-17 10:06:14 -0600
commitaf4d3643864ee5fcba0c97d77a424fa0b0346f8e (patch)
treeed8af088c50a41c011abde88bf970a4faa28b1dc /arch
parent28707af01b8912e701e3c5b619ff8f6dde8f2e81 (diff)
downloadop-kernel-dev-af4d3643864ee5fcba0c97d77a424fa0b0346f8e.zip
op-kernel-dev-af4d3643864ee5fcba0c97d77a424fa0b0346f8e.tar.gz
powerpc: Fix corruption error in rh_alloc_fixed()
There is an error in rh_alloc_fixed() of the Remote Heap code: If there is at least one free block blk won't be NULL at the end of the search loop, so -ENOMEM won't be returned and the else branch of "if (bs == s || be == e)" will be taken, corrupting the management structures. Signed-off-by: Guillaume Knispel <gknispel@proformatique.com> Acked-by: Timur Tabi <timur@freescale.com> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Diffstat (limited to 'arch')
-rw-r--r--arch/powerpc/lib/rheap.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/lib/rheap.c b/arch/powerpc/lib/rheap.c
index 29b2941..45907c1 100644
--- a/arch/powerpc/lib/rheap.c
+++ b/arch/powerpc/lib/rheap.c
@@ -556,6 +556,7 @@ unsigned long rh_alloc_fixed(rh_info_t * info, unsigned long start, int size, co
be = blk->start + blk->size;
if (s >= bs && e <= be)
break;
+ blk = NULL;
}
if (blk == NULL)
OpenPOWER on IntegriCloud