diff options
| author | Stefan Weil <weil@mail.berlios.de> | 2011-01-30 20:26:27 +0100 |
|---|---|---|
| committer | Kevin Hilman <khilman@ti.com> | 2011-01-31 12:59:15 -0800 |
| commit | 720bc782249015a30438516cee5c4be180a3f675 (patch) | |
| tree | 2cd247c2da8924edd6e192ea4223825b6fa0d225 /arch | |
| parent | 62270119867131d6d11fe018f1fafcf0fa2933e3 (diff) | |
| download | op-kernel-dev-720bc782249015a30438516cee5c4be180a3f675.zip op-kernel-dev-720bc782249015a30438516cee5c4be180a3f675.tar.gz | |
OMAP: PM: SmartReflex: Fix possible memory leak
sr_info was allocated and needs a kfree before returning.
This error was reported by cppcheck:
arch/arm/mach-omap2/smartreflex.c:837: error: Memory leak: sr_info
To: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Acked-by: Shweta Gulati <shweta.gulati@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/arm/mach-omap2/smartreflex.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index d7deadf..5f429b9 100644 --- a/arch/arm/mach-omap2/smartreflex.c +++ b/arch/arm/mach-omap2/smartreflex.c @@ -834,7 +834,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) if (!pdata) { dev_err(&pdev->dev, "%s: platform data missing\n", __func__); - return -EINVAL; + ret = -EINVAL; + goto err_free_devinfo; } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
