diff options
| author | Hideo Saito <saito@densan.co.jp> | 2007-02-28 18:35:42 +0900 |
|---|---|---|
| committer | Paul Mundt <lethal@linux-sh.org> | 2007-03-05 14:13:26 +0900 |
| commit | e6bcf562e58662b9765748d346e4c076b20e3aa5 (patch) | |
| tree | 0c8982c11cd410f4b654b8fda9a1a1fc6776e4a3 /arch | |
| parent | e523d93c8487667552dd29ff756d6ea6bce30851 (diff) | |
| download | op-kernel-dev-e6bcf562e58662b9765748d346e4c076b20e3aa5.zip op-kernel-dev-e6bcf562e58662b9765748d346e4c076b20e3aa5.tar.gz | |
sh: Fix kernel thread stack corruption with preempt.
When I run a preemptive kernel-2.6.20 for SH7780, a created
kthread(pdflush) can not exit by do_exit() in kernel_thread_helper. I
think that the created kthread should have a room for 'struct pt_regs'
space on the stack top, because __switch_to() will refer to the space as
follows using 'regs = task_pt_regs(prev)' and next condition may be true.
Signed-off-by: Hideo Saito <saito@densan.co.jp>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/sh/kernel/process.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/arch/sh/kernel/process.c b/arch/sh/kernel/process.c index 9d6a438..e760736 100644 --- a/arch/sh/kernel/process.c +++ b/arch/sh/kernel/process.c @@ -250,12 +250,11 @@ int copy_thread(int nr, unsigned long clone_flags, unsigned long usp, childregs->regs[15] = usp; ti->addr_limit = USER_DS; } else { - childregs->regs[15] = (unsigned long)task_stack_page(p) + - THREAD_SIZE; + childregs->regs[15] = (unsigned long)childregs; ti->addr_limit = KERNEL_DS; } - if (clone_flags & CLONE_SETTLS) + if (clone_flags & CLONE_SETTLS) childregs->gbr = childregs->regs[0]; childregs->regs[0] = 0; /* Set return value for child */ |
