summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2007-10-15 20:45:32 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-17 16:25:10 -0700
commit4209ab098c61b1a9684bb4d3fc287352fc2438c3 (patch)
tree5f8862485df17c6ab87cb8396280f14ab03a3e9b /arch
parent719023fb90009855c4515a16349fc6d0a2f93a74 (diff)
downloadop-kernel-dev-4209ab098c61b1a9684bb4d3fc287352fc2438c3.zip
op-kernel-dev-4209ab098c61b1a9684bb4d3fc287352fc2438c3.tar.gz
[SPARC64]: Check of_get_property() return in pci_determine_mem_io_space().
If the PCI controller lacks the 'ranges' property nothing is going to work. Noticed by Al Viro. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch')
-rw-r--r--arch/sparc64/kernel/pci_common.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/arch/sparc64/kernel/pci_common.c b/arch/sparc64/kernel/pci_common.c
index c76bfbb..923e0bc 100644
--- a/arch/sparc64/kernel/pci_common.c
+++ b/arch/sparc64/kernel/pci_common.c
@@ -396,6 +396,13 @@ void pci_determine_mem_io_space(struct pci_pbm_info *pbm)
saw_mem = saw_io = 0;
pbm_ranges = of_get_property(pbm->prom_node, "ranges", &i);
+ if (!pbm_ranges) {
+ prom_printf("PCI: Fatal error, missing PBM ranges property "
+ " for %s\n",
+ pbm->name);
+ prom_halt();
+ }
+
num_pbm_ranges = i / sizeof(*pbm_ranges);
for (i = 0; i < num_pbm_ranges; i++) {
OpenPOWER on IntegriCloud