summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorFernando Vazquez <fernando@intellilink.co.jp>2006-09-30 23:29:10 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2006-10-01 00:39:31 -0700
commitbc03613decef0cc4d2f3a24f19fa5a868745715f (patch)
tree7c3343b100ae399df29815d709e4ab01768141ca /arch
parentce53af9496c625a8ae33526713be34a23756db19 (diff)
downloadop-kernel-dev-bc03613decef0cc4d2f3a24f19fa5a868745715f.zip
op-kernel-dev-bc03613decef0cc4d2f3a24f19fa5a868745715f.tar.gz
[PATCH] stack overflow safe kdump: safe smp_send_nmi_allbutself()
Re-implement smp_send_nmi_allbutself() so that calls to smp_processor_id (through send_IPI_allbutself) can be replaced with safe_smp_processor_id without affecting other parts of the kernel (as suggested by Eric Biederman). Signed-off-by: Fernando Vazquez <fernando@intellilink.co.jp> Looks-reasonable-to: Andi Kleen <ak@muc.de> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Vivek Goyal <vgoyal@in.ibm.com> Cc: James Bottomley <James.Bottomley@steeleye.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch')
-rw-r--r--arch/i386/kernel/crash.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c
index 2dfc049..144b432 100644
--- a/arch/i386/kernel/crash.c
+++ b/arch/i386/kernel/crash.c
@@ -134,7 +134,10 @@ static int crash_nmi_callback(struct notifier_block *self,
static void smp_send_nmi_allbutself(void)
{
- send_IPI_allbutself(NMI_VECTOR);
+ cpumask_t mask = cpu_online_map;
+ cpu_clear(safe_smp_processor_id(), mask);
+ if (!cpus_empty(mask))
+ send_IPI_mask(mask, NMI_VECTOR);
}
static struct notifier_block crash_nmi_nb = {
OpenPOWER on IntegriCloud