summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorBruno Randolf <br1@einfach.org>2008-09-25 16:45:10 +0200
committerRalf Baechle <ralf@linux-mips.org>2008-09-27 15:45:35 +0100
commit19506fc51852e859bb08ab5abbdb8fd02b7392f2 (patch)
tree9c6352c3de58feb9651d4488232db81b6ac231c7 /arch
parent6ef190cc92e33565accff6a320f0e7d90480bfe7 (diff)
downloadop-kernel-dev-19506fc51852e859bb08ab5abbdb8fd02b7392f2.zip
op-kernel-dev-19506fc51852e859bb08ab5abbdb8fd02b7392f2.tar.gz
[MIPS] au1000: Make sure GPIO value is zero or one
David Brownell <david-b@pacbell.net> wrote: > The problem is that "value" is zero-or-nonzero. > This code wrongly assumes it's zero-or-one. > Possible fix: "((!!value) << gpio)". Signed-off-by: Bruno Randolf <br1@einfach.org> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch')
-rw-r--r--arch/mips/au1000/common/gpio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/mips/au1000/common/gpio.c b/arch/mips/au1000/common/gpio.c
index 1f05843..e660ddd 100644
--- a/arch/mips/au1000/common/gpio.c
+++ b/arch/mips/au1000/common/gpio.c
@@ -48,7 +48,7 @@ static void au1xxx_gpio2_write(unsigned gpio, int value)
{
gpio -= AU1XXX_GPIO_BASE;
- gpio2->output = (GPIO2_OUTPUT_ENABLE_MASK << gpio) | (value << gpio);
+ gpio2->output = (GPIO2_OUTPUT_ENABLE_MASK << gpio) | ((!!value) << gpio);
}
static int au1xxx_gpio2_direction_input(unsigned gpio)
@@ -62,7 +62,7 @@ static int au1xxx_gpio2_direction_output(unsigned gpio, int value)
{
gpio -= AU1XXX_GPIO_BASE;
gpio2->dir |= 0x01 << gpio;
- gpio2->output = (GPIO2_OUTPUT_ENABLE_MASK << gpio) | (value << gpio);
+ gpio2->output = (GPIO2_OUTPUT_ENABLE_MASK << gpio) | ((!!value) << gpio);
return 0;
}
OpenPOWER on IntegriCloud