summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorKieran Bingham <kieran.bingham@ideasonboard.com>2018-03-26 09:29:17 -0400
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2018-04-04 06:27:28 -0400
commit639fa43d59e5a41ca8c55592cd5c1021fea2ab83 (patch)
treeacd4968cfda7204acfb247142b718aa9af951175 /arch
parent19ad26f9e6e1decdde6d48fe1849a06a103b0f09 (diff)
downloadop-kernel-dev-639fa43d59e5a41ca8c55592cd5c1021fea2ab83.zip
op-kernel-dev-639fa43d59e5a41ca8c55592cd5c1021fea2ab83.tar.gz
media: vsp1: Fix BRx conditional path in WPF
When a BRx is provided by a pipeline, the WPF must determine the master layer. Currently the condition to check this identifies pipe->bru || pipe->num_inputs > 1. The code then moves on to dereference pipe->bru, thus the check fails static analysers on the possibility that pipe->num_inputs could be greater than 1 without pipe->bru being set. The reality is that the pipeline must have a BRx to support more than one input, thus this could never cause a fault - however it also identifies that the num_inputs > 1 check is redundant. Remove the redundant check - and always configure the master layer appropriately when we have a BRx configured in our pipeline. Fixes: 6134148f6098 ("v4l: vsp1: Add support for the BRS entity") Cc: stable@vger.kernel.org Suggested-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud