diff options
| author | Johannes Weiner <jw@emlix.com> | 2009-03-04 16:21:29 +0100 |
|---|---|---|
| committer | Chris Zankel <chris@zankel.net> | 2009-04-02 23:38:57 -0700 |
| commit | 28a0ce7f642f503dde866f763e8144a517fdf74a (patch) | |
| tree | e898e20dd046957a1598da24802c1d8630f21146 /arch/xtensa/kernel | |
| parent | 35f9cd083b350ad4eb3b5f159c7738fa9ddff40a (diff) | |
| download | op-kernel-dev-28a0ce7f642f503dde866f763e8144a517fdf74a.zip op-kernel-dev-28a0ce7f642f503dde866f763e8144a517fdf74a.tar.gz | |
xtensa: use correct stack pointer for stack traces
Right now, the xtensa stacktrace code reads the _current_ kernel stack
pointer if nothing is supplied. With debugging facilities like sysrq
this means that the backtrace of the sysrq-handler is printed instead
of a trace of the given task's stack.
When no stack pointer is specified in show_trace() and show_stack(),
use the stack pointer that comes with the handed in task descriptor to
make stack traces more useful.
Signed-off-by: Johannes Weiner <jw@emlix.com>
Signed-off-by: Chris Zankel <chris@zankel.net>
Diffstat (limited to 'arch/xtensa/kernel')
| -rw-r--r-- | arch/xtensa/kernel/traps.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/arch/xtensa/kernel/traps.c b/arch/xtensa/kernel/traps.c index c44f830..6b4a9d7 100644 --- a/arch/xtensa/kernel/traps.c +++ b/arch/xtensa/kernel/traps.c @@ -372,11 +372,10 @@ void show_trace(struct task_struct *task, unsigned long *sp) unsigned long a0, a1, pc; unsigned long sp_start, sp_end; - a1 = (unsigned long)sp; - - if (a1 == 0) - __asm__ __volatile__ ("mov %0, a1\n" : "=a"(a1)); - + if (sp) + a1 = (unsigned long)sp; + else + a1 = task->thread.sp; sp_start = a1 & ~(THREAD_SIZE-1); sp_end = sp_start + THREAD_SIZE; @@ -418,9 +417,8 @@ void show_stack(struct task_struct *task, unsigned long *sp) int i = 0; unsigned long *stack; - if (sp == 0) - __asm__ __volatile__ ("mov %0, a1\n" : "=a"(sp)); - + if (!sp) + sp = (unsigned long *)task->thread.sp; stack = sp; printk("\nStack: "); |
