diff options
| author | Ingo Molnar <mingo@elte.hu> | 2009-05-03 10:09:03 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-05-03 10:09:03 +0200 |
| commit | a454ab3110175d710f4f9a96226a26ce4d5d5de2 (patch) | |
| tree | 5244b639232b2fe7d9c8806ed784881042967607 /arch/x86/mm/fault.c | |
| parent | 9518e0e4350a5ea8ca200ce320b28d6284a7b0ce (diff) | |
| download | op-kernel-dev-a454ab3110175d710f4f9a96226a26ce4d5d5de2.zip op-kernel-dev-a454ab3110175d710f4f9a96226a26ce4d5d5de2.tar.gz | |
x86, mm: fault.c, use printk_once() in is_errata93()
Andrew pointed out that the 'once' variable has a needlessly
function-global scope. We can in fact eliminate it completely,
via the use of printk_once().
[ Impact: cleanup ]
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/mm/fault.c')
| -rw-r--r-- | arch/x86/mm/fault.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 24a36a6..b9ca6d7 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c @@ -514,8 +514,6 @@ bad: static int is_errata93(struct pt_regs *regs, unsigned long address) { #ifdef CONFIG_X86_64 - static int once; - if (address != regs->ip) return 0; @@ -525,10 +523,7 @@ static int is_errata93(struct pt_regs *regs, unsigned long address) address |= 0xffffffffUL << 32; if ((address >= (u64)_stext && address <= (u64)_etext) || (address >= MODULES_VADDR && address <= MODULES_END)) { - if (!once) { - printk(errata93_warning); - once = 1; - } + printk_once(errata93_warning); regs->ip = address; return 1; } |
